Skip to content

fix: wrong term #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2022
Merged

fix: wrong term #532

merged 1 commit into from
Jul 23, 2022

Conversation

svirins
Copy link
Contributor

@svirins svirins commented Jun 29, 2022

it should be 'time' instead of 'speed'

@svirins
fix: wrong term
fb2d221 
it should be 'time' instead of 'speed'
eps1lon
eps1lon approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just missing a yarn gen-readme locally, committing changes and we can merge.

@filiptammergard
Copy link
Collaborator

Thanks! Just missing a yarn gen-readme locally, committing changes and we can merge.

I guess this is the downside or enforcing a local yarn gen-readme, as many people are opening PRs like this through the GitHub UI and not in an IDE, it increases the effort 🙂

@eps1lon
Copy link
Member

eps1lon commented Jun 29, 2022

Yep. I said as much when I implemented it.

@filiptammergard filiptammergard merged commit 0d94cb6 into typescript-cheatsheets:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svirins @filiptammergard @eps1lon