Skip to content

Recommend @ts-expect-error over @ts-ignore #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Mar 8, 2022

it's better to use expect error rather than ts-ignore as it will show up as an error if the type get's fixed

Thanks for contributing!

  • If you are making a significant PR, please make sure there is an open issue first
  • If you're just fixing typos or adding small notes, a brief explanation of why you'd like to add it would be nice :)

If you are contributing to README.md, DON'T. README.md is auto-generated. Please just make edits to the source inside of /docs/basic. Sorry, we get that it is a slight pain.

capaj and others added 2 commits March 8, 2022 20:47
it's better to use expect error rather than `ts-ignore`
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍🏻

@eps1lon eps1lon changed the title tweak migration doc Recommend @ts-expect-error over @ts-ignore Mar 9, 2022
@eps1lon eps1lon merged commit bf54bf2 into typescript-cheatsheets:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants