document new VoidFunctionComponent type #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdaber
approved these changes
Aug 19, 2020
eps1lon
requested changes
Aug 19, 2020
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
|
ah so i misunderstood the intent of VFC. i've updated wording now, thanks to you both |
eps1lon
requested changes
Aug 20, 2020
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
|
Also needs a format 😉 |
|
sigh. i need to fix that gh action to do it for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #268
cc @eps1lon if any other comments need be added, if not i will circle back n merge
other maintainers also welcome to help tweak wording