Support ignoreUnknownValues and skipInvalidRows option for insertAll #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1137,7 +1137,8 @@ def wait_for_job(self, job, interval=5, timeout=60): | |||
|
|
|||
| return job_resource | |||
|
|
|||
| def push_rows(self, dataset, table, rows, insert_id_key=None): | |||
| def push_rows(self, dataset, table, rows, insert_id_key=None, | |||
| skip_invalid_rows=None, ignore_unknown_values=None): | |||
There was a problem hiding this comment.
Any reason you default these to None rather than False?
There was a problem hiding this comment.
To keep current behavior. Current behavior neither send True nor send False.
|
Minor comment, otherwise LGTM. Is this still a WIP? |
|
Also, maybe want to include the new options in a unit test. |
hagino3000
changed the title
|
@tylertreat Thanks. I added unit tests and checked actual result of |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now BigQuery support
ignoreUnknownValuesandskipInvalidRowsoption for InsertAll.https://cloud.google.com/bigquery/docs/reference/v2/tabledata/insertAll
I added two options to push_rows method.