Add service_url parameter to get_client and _get_bq_service #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the unit tests need to be updated to include the new kwarg in |
|
Sorry about that @tylertreat! |
|
Thanks! |
tylertreat
added a commit
that referenced
this pull request
Feb 11, 2016
Add service_url parameter to get_client and _get_bq_service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (the company I work for) are wanting to use this library but don't want to resort to a lot of hackery to get it talk to our externally mocked BigQuery service. This small and entirely non-functional change allows the user to specify the BigQuery service URL used. If it's not provided then behavior is as before.