Render query modifications #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add basic 'HAVING' clause (before the 'ORDER BY' clause). 2. Select source tables in 'DATE_RANGE' format. 3. Add 'BETWEEN' clause in conditions. 4. Modify 'ORDER BY' to accept multiple parameters.
Test cases modified as the ORDER_BY syntax has changed and HAVING clause also has been added.
Update Table and Patch Table support has been added.
Render the conditions for the having clause. Moved the 'GROUP BY' clause defination abouve 'HAVING'.
Check the length of the value is 2, when BETWEEN is used. If length is not equal to 2 throw warning.
| else: | ||
| return {} | ||
|
|
||
| def patch_table(self, dataset, table, schema, expiration_time=None): |
There was a problem hiding this comment.
patch_table already exists: https://github.com/tylertreat/BigQuery-Python/blob/master/bigquery/client.py#L487
|
It looks like the client.py changes don't belong with the query_builder.py changes. |
|
Removed the client.py changes from the query_builder.py On Wed, Feb 3, 2016 at 5:00 AM, Tyler Treat notifications@github.com
|
Deleted the un-correct code for patch_table and update_table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the query builder API.