Create parent directories of nested SourceFile #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, createNewFile() fails if you have a SourceFile in a directory, since it can't create the owning directory.
|
This fixes Issue #340. |
|
@tschuchortdev please let me know if this PR needs anything! |
|
Hi @tschuchortdev, I need this feature. Can you review this PR? |
|
Thanks for this PR! I'm sorry I didn't get to it sooner. Your work is appreciated and will be in the next release, which I'm about to start. |
ianlevesque
pushed a commit
to facebookincubator/kotlin-compile-testing
that referenced
this pull request
Mar 6, 2023
Currently, createNewFile() fails if you have a SourceFile in a directory, since it can't create the owning directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
createNewFile()fails if you have aSourceFilein a directory, since it can't create the owning directory.Calling
mkdirs()on the parent directory fixes this, and has no effect if the path already exists.