Skip to content

feat: closing task #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Aug 20, 2020

ref issue #693

  • Button to close the task added to the edit page, but not the list, as confirmed by Vikas No way to close a challenge of type TASK #693 (comment)

    image

  • As not all the fields which are needed to close a task are required in the form, I've added an error message which asks user to fill all the fields for closing task:

    image

  • If all required info is there and user clicks Close Task button, there is a confirmation dialog:

    image

  • If user clicks Confirm form is being processed and a standard successful message is showing:

    image

    Though at the moment when I'm trying to close the task with the assigned member who is added as a winner there is an error. I guess setting task.memberId doesn't add the user to the challenge, because when I send the same request but without winners array it works, and the challenge is marked as completed:

    image

@vikasrohit
Copy link

LGTM. Will debug the sync issue with legacy challenge processor after merging in dev.

@vikasrohit vikasrohit merged commit 634fc17 into topcoder-platform:develop Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants