fix(PM-1169): send source to accept or decline invite API #1650
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -42,9 +44,9 @@ const ProjectInvitations = ({ match, auth, isProjectLoading, history, projectDet | |||
| } | |||
| }, [projectId, auth, projectDetail, isProjectLoading, history]) | |||
|
|
|||
| const updateInvite = useCallback(async (status) => { | |||
| const updateInvite = useCallback(async (status, source) => { | |||
There was a problem hiding this comment.
The updateInvite function now requires a source parameter, but it's not clear from the diff how this parameter is being passed when updateInvite is called. Ensure that all calls to updateInvite are updated to include the source argument.
| @@ -56,8 +58,8 @@ const ProjectInvitations = ({ match, auth, isProjectLoading, history, projectDet | |||
| history.push(status === PROJECT_MEMBER_INVITE_STATUS_ACCEPTED ? `/projects/${projectId}/challenges` : '/projects') | |||
| }, [projectId, invitation, loadProjectInvites, history]) | |||
|
|
|||
| const acceptInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_ACCEPTED), [updateInvite]) | |||
| const declineInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_REFUSED), [updateInvite]) | |||
| const acceptInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_ACCEPTED, source), [updateInvite, source]) | |||
There was a problem hiding this comment.
The variable source is used here, but it is not clear from the diff where it is defined or how it is being set. Ensure that source is properly initialized and passed to this component.
| const acceptInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_ACCEPTED), [updateInvite]) | ||
| const declineInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_REFUSED), [updateInvite]) | ||
| const acceptInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_ACCEPTED, source), [updateInvite, source]) | ||
| const declineInvite = useCallback(() => updateInvite(PROJECT_MEMBER_INVITE_STATUS_REFUSED, source), [updateInvite, source]) |
There was a problem hiding this comment.
Similar to the previous line, ensure that the source variable is correctly defined and initialized before being used in this function.
| @@ -8,9 +8,9 @@ import { PROJECTS_API_URL } from '../config/constants' | |||
| * @param {string} status the new status for invitation | |||
| * @return {object} project member invite returned by api | |||
| */ | |||
| export function updateProjectMemberInvite (projectId, inviteId, status) { | |||
| export function updateProjectMemberInvite (projectId, inviteId, status, source) { | |||
There was a problem hiding this comment.
The function updateProjectMemberInvite now includes a new parameter source. Ensure that all calls to this function in the codebase are updated to pass this new parameter to avoid potential runtime errors.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-1169