fix(PM-1140): show spinner when changing between projects #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -251,7 +253,7 @@ class Users extends Component { | |||
| ) | |||
| } | |||
| { | |||
| membersExist && ( | |||
| !isLoadingProject && membersExist && ( | |||
There was a problem hiding this comment.
Consider adding a check for isLoadingProject before membersExist to ensure that the spinner is shown correctly when the project is loading. This change may affect the rendering logic, so ensure that isLoadingProject is correctly initialized and updated to reflect the loading state accurately.
| @@ -80,9 +81,10 @@ class Users extends Component { | |||
| } | |||
|
|
|||
| loadProject (projectId) { | |||
| this.setState({ isLoadingProject: true }) | |||
There was a problem hiding this comment.
Consider handling potential errors from fetchProjectById to ensure isLoadingProject is set back to false in case of a failure. This will prevent the spinner from being displayed indefinitely.
kkartunov
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?