PM-973 - fix checkIsUserInvitedToProject #1636
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,7 +3,7 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react' | |||
| import { connect } from 'react-redux' | |||
| import { withRouter } from 'react-router-dom' | |||
| import { toastr } from 'react-redux-toastr' | |||
| import { checkIsUserInvited } from '../../util/tc' | |||
| import { checkIsUserInvitedToProject } from '../../util/tc' | |||
There was a problem hiding this comment.
The import statement has been updated to use checkIsUserInvitedToProject. Ensure that this function is correctly defined and exported in ../../util/tc and that all references to checkIsUserInvited in this file and others are updated accordingly.
| @@ -233,13 +233,13 @@ export const checkAdminOrCopilot = (token, project) => { | |||
| return isAdmin || (isCopilot && canManageProject) | |||
| } | |||
|
|
|||
| export const checkIsUserInvited = (token, project) => { | |||
| export const checkIsUserInvitedToProject = (token, project) => { | |||
| if (!token) { | |||
There was a problem hiding this comment.
Consider returning a specific value (e.g., false) instead of undefined when the token is not provided, to maintain consistency in return types.
| if (!token) { | ||
| return | ||
| } | ||
|
|
||
| const tokenData = decodeToken(token) | ||
| return project && !_.isEmpty(project) && _.find(project.invites, { userId: tokenData.userId }) | ||
| return project && !_.isEmpty(project) && (_.find(project.invites, d => d.userId === tokenData.userId || d.email === tokenData.email)) |
There was a problem hiding this comment.
The condition now checks for both userId and email. Ensure that this change aligns with the intended logic and that it does not introduce any security or logic issues, such as allowing access based on email when it should be restricted to userId.
No description provided.