Skip to content

PM-226 Fix React bad practice: dangerouslySetInnerhtml #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

PM-226 Fix React bad practice: dangerouslySetInnerhtml #1594

merged 1 commit into from
Dec 16, 2024

Conversation

himaniraghav3
Copy link
Collaborator

What's in this PR?

https://topcoder.atlassian.net/browse/PM-226

  • Replaces the dangerouslySetInnerhtml with explicit plaintext render

vas3a
vas3a approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. looks good.
Lol because of 2 things:

  • why did they use dangerouslySetInnerHTML
  • it clearly used xss to parse and prevent the security issues, but the assessment tool didn't took it into consideration.

@himaniraghav3 himaniraghav3 merged commit b571de1 into develop Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vas3a vas3a vas3a approved these changes

@kkartunov kkartunov Awaiting requested review from kkartunov

@hentrymartin hentrymartin Awaiting requested review from hentrymartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himaniraghav3 @vas3a