Skip to content

PM-225 Fix privacy violation related to cookie #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2024
Merged

PM-225 Fix privacy violation related to cookie #1590

merged 2 commits into from
Dec 11, 2024

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Removed cookie files as I've changed the logic to use local storage.
  • This should fix the security violation

vas3a
vas3a reviewed Dec 10, 2024
View reviewed changes
vas3a
vas3a approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as long as you were able to test and ensured the previous behavior is still working.

@hentrymartin hentrymartin merged commit 5ec54e9 into develop Dec 11, 2024
2 checks passed
@hentrymartin hentrymartin deleted the pm-225 branch December 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vas3a vas3a vas3a approved these changes

@kkartunov kkartunov kkartunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hentrymartin @vas3a @kkartunov