Oct 2022 release #1423
Merged
Oct 2022 release #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1412 1. A "project" contains "status" field , this status field can be "active"/"in_review" 2. A "project" also has a billingAccount mapped. 3. Application makes a GET call with billingAccount id to get billingAccount details. and response of it is this screenshot https://imgur.com/cU3s4yU 4. response has "active" boolean field and enddate field which is correctly utilised in reducer code to set the flag "isBillingAccountExpired". check this screenshot https://imgur.com/l5nyxbt 5. now this "isBillingAccountExpired" flag is used like this. check screenshot https://imgur.com/mjDhbAF 6. when "isBillingAccountExpired" is true, we show hardcoded "INACTIVE" which is correct. 7. but when "isBillingAccountExpired" is false , we show "status" field of "project" which is wrong, because we need to show whether billingAccount is active or not. 8. hence "status" field of project can be active/inReview , thats why u see "IN_REVIEW" in UI, 9. hence my solution/approach is that flag "isBillingAccountExpired" is already there which clearly indicates active/inactive, hence i hardcoded "ACTIVE" in code because it is obvious. # Conflicts: # src/components/ChallengesComponent/ChallengeList/index.js
#1418 # Conflicts: # src/components/ChallengeEditor/ChallengeView/index.js # src/components/ChallengeEditor/index.js
#1420 # Conflicts: # src/config/constants.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/topcoder-platform/work-manager/milestone/26