Skip to content

fix issue-#1058 #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Conversation

mark-nakachon
Copy link
Contributor

No description provided.

@mark-nakachon mark-nakachon mentioned this pull request Jan 29, 2021
@vikasrohit
Copy link

Thanks @mark-nakachon for the PR. @maxceem is out for couple of days, he would do the detailed review when he is back. However, meanwhile when I tried your PR on my local, it worked great and as per my expectations with only weird case where when I set beta=true on /projects/{projectId}/challenges page then I am able to unset the beta mode only when I am on the same page i.e. I am not able to unset beta mode on /projects/{projectId}/challenges/{challengeId}/view or /projects/{projectId}/challenges/{challengeId}/edit. While in reverse case when I am set beta mode on /projects/{projectId}/challenges/{challengeId}/view or /projects/{projectId}/challenges/{challengeId}/edit, I am able to unset it from /projects/{projectId}/challenges.

@mark-nakachon
Copy link
Contributor Author

@vikasrohit it's a path issue it's fixed now, Can you try again now

@vikasrohit
Copy link

@mark-nakachon it works now. Thanks. @maxceem I am merging the PR for now ahead of demo, please review the PR once you are back. I didn't see any specific issue with the PR.

@vikasrohit vikasrohit merged commit 0c8b878 into topcoder-platform:develop Jan 30, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 1, 2021

@vikasrohit @mark-nakachon I did the review of this PR and it looks great for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants