Skip to content

added assign to me button #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

nursoltan-s
Copy link
Collaborator

No description provided.

@nursoltan-s nursoltan-s changed the base branch from develop to cf-jan-2021 January 9, 2021 11:45
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nursoltan-s works good, but there was one small requirement update, instead of a button we have to add a smile blue hyperlink, see #1017 (comment). Could you please, replace the button with a simple hyperlink so it doesn't take so much attention.

@nursoltan-s
Copy link
Collaborator Author

@maxceem changed button to hyperlink

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update @nursoltan-s.

When we click the link, then # is added to the URL. Can we avoid it to keep things clear?

image

@nursoltan-s
Copy link
Collaborator Author

@maxceem updated.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nursoltan-s link is good now. But noticed one more thing, we should not show this link on the view page, only during editing:

image

@nursoltan-s
Copy link
Collaborator Author

@maxceem updated

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nursoltan-s it looks like we already have a flag that can be used to detect if we are in Edit or View mode, called readOnly. We set it in view mode https://github.com/topcoder-platform/work-manager/blob/cf-jan-2021/src/components/ChallengeEditor/ChallengeView/index.js#L138. So it could be used to hide the assign me link, and we don't have to add a new flag isEdit.

@nursoltan-s
Copy link
Collaborator Author

@nursoltan-s it looks like we already have a flag that can be used to detect if we are in Edit or View mode, called readOnly. We set it in view mode https://github.com/topcoder-platform/work-manager/blob/cf-jan-2021/src/components/ChallengeEditor/ChallengeView/index.js#L138. So it could be used to hide the assign me link, and we don't have to add a new flag isEdit.

But. readOnly flag was set to false on both pages(edit and view pages)

@maxceem
Copy link
Contributor

maxceem commented Jan 11, 2021

@nursoltan-s hmm, it's true for me.

The next line <AssignedMemberField challenge={challenge} assignedMemberDetails={assignedMemberDetails} readOnly /> is equal to <AssignedMemberField challenge={challenge} assignedMemberDetails={assignedMemberDetails} readOnly={true} />.

image

@nursoltan-s
Copy link
Collaborator Author

@maxceem sorry. Updated the brand. Can you please check now?

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick updates @nursoltan-s. All perfect now.

@maxceem maxceem merged commit 38bf8ef into topcoder-platform:cf-jan-2021 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants