-
Notifications
You must be signed in to change notification settings - Fork 51
added assign to me button #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added assign to me button #1027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nursoltan-s works good, but there was one small requirement update, instead of a button we have to add a smile blue hyperlink, see #1017 (comment). Could you please, replace the button with a simple hyperlink so it doesn't take so much attention.
@maxceem changed button to hyperlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update @nursoltan-s.
When we click the link, then #
is added to the URL. Can we avoid it to keep things clear?
@maxceem updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nursoltan-s link is good now. But noticed one more thing, we should not show this link on the view page, only during editing:
@maxceem updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nursoltan-s it looks like we already have a flag that can be used to detect if we are in Edit or View mode, called readOnly
. We set it in view mode https://github.com/topcoder-platform/work-manager/blob/cf-jan-2021/src/components/ChallengeEditor/ChallengeView/index.js#L138. So it could be used to hide the assign me
link, and we don't have to add a new flag isEdit
.
But. |
@nursoltan-s hmm, it's The next line |
0a55528
to
283b9d9
Compare
@maxceem sorry. Updated the brand. Can you please check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick updates @nursoltan-s. All perfect now.
No description provided.