Sometimes user can save a draft without a Public specification

[codejamtc]

6.zip

Steps to reproduce the problem

1. Open https://challenges.topcoder-dev.com/ and login as Admin
2. Select a project from the list 'Test v5 {codejam} - 0001'
3. Go to Draft and select a QA Task
4. Click 'Edit' https://challenges.topcoder-dev.com/projects/16604/challenges/f6741d0c-94e8-41fd-9037-91614aa2e4a3/edit
5. Remove the Public specification data
6. Click 'Save Draft' (Validation: Public Specification is required)
7. Remove the Public specification data
8. Click 'Back'
9. Select the same task in Step 03
10. Check the Public specification data

Actual behavior

• Sometimes user can save a draft without a Public specification

Expected behavior

• Should display the old specification in this case

Environment

- OS: HP 15-dw1xxx 15.6 inch; Window 10
- Browser (w/version): Chrome 85.0.4183.83
- User role (client, copilot or manager): Admin
- Account used: TonyJ

[codejamtc]

#856

[maxceem]

This wouldn't happen now because API doesn't allow empty description anymore. But there is still incorrect behavior of the UI too. So this might also happen for other fields.

This is issue with autosave

• When we change the description autosave works and it saves the challenge without validation.
• When we click Save Draft the description field got unfocused, and autosave saves the challenge again.

See demo video https://monosnap.com/file/8aY31JrKdH6amj65t0fWmJXt3gRw2E

@vikasrohit what do you think we should do with autosave when the user cleans the description?

1. Should we silently skip autosaving if the form is invalid?
2. Should we show validation errors immediately when the user edits the form and autosave works?

[vikasrohit]

@maxceem I think we can show validation error on edit in challenge description to prevent this situation because we are already showing other validation errors immediately after the form is dirty.

[vikasrohit]

@codejamtc fyi, we are not able to reproduce the original issue and we are working on missing validation case for auto saving. If you are still able to reproduce original issue, please let us know.

[vikasrohit]

@drasticdpk @lakshmiathreya Can we try to reproduce it with original steps? We are not able to reproduce it but we have identified one missing validation error situation which might confuse users, so we would fix that if the original one is not reproducible.

[vikasrohit]

@maxceem can you please add validation error for the patch call as well?

[maxceem]

can you please add validation error for the patch call as well?

Do you mean add validation to PATCH request server side?

Or do you mean show validation error when auto-save is triggered?