Skip to content

Commit 78f573b

Browse files
author
vikasrohit
authored
Merge pull request #983 from topcoder-platform/develop
Prod update - fixed failed QA issue
2 parents 82c5747 + 089005f commit 78f573b

File tree

7 files changed

+26
-125
lines changed

7 files changed

+26
-125
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
### Expected behavior
2+
Describe.
3+
4+
### Actual behavior
5+
Describe.
6+
7+
### Steps to reproduce the problem
8+
- TBD.
9+
- TBD.
10+
- TBD.
11+
12+
### Screenshot/screencast
13+
Attach or link a resource.
14+
15+
--
16+
17+
#### Environment
18+
- OS:
19+
- Browser (w/version):
20+
- User role (client, copilot or manager):
21+
- Account used:

.github/ISSUE_TEMPLATE/may-7-bug-hunt-functionality-bug.md

Lines changed: 0 additions & 32 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/may-7-bug-hunt-security-bug.md

Lines changed: 0 additions & 32 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/may-7-bug-hunt-suggestion.md

Lines changed: 0 additions & 27 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/may-7-bug-hunt-user-interface-bug.md

Lines changed: 0 additions & 32 deletions
This file was deleted.

src/components/ChallengeEditor/TextEditor-Field/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class TextEditorField extends Component {
5252
readOnly={readOnly}
5353
/>
5454
</div>)}
55-
{challenge.submitTriggered && !challenge.description && (
55+
{challenge.submitTriggered && (challenge.description || '').trim().length === 0 && (
5656
<div className={styles.error}>Public Specification is required</div>
5757
)}
5858
{!readOnly && shouldShowPrivateDescription && !showShowPrivateDescriptionField && (<div className={styles.button} onClick={this.addNewPrivateDescription}>

src/components/ChallengeEditor/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,10 @@ class ChallengeEditor extends Component {
673673
const value = challenge[key]
674674

675675
// this check works for string and array values
676-
isRequiredMissing = isRequiredMissing || !value || !value.length
676+
isRequiredMissing = isRequiredMissing ||
677+
!value ||
678+
(_.isString(value) && value.trim().length === 0) ||
679+
(_.isArray(value) && value.length === 0)
677680
})
678681

679682
return !(isRequiredMissing || _.isEmpty(this.state.currentTemplate))

0 commit comments

Comments
 (0)