Skip to content

Commit 089005f

Browse files
author
vikasrohit
authored
Merge pull request #982 from maxceem/issue-778
fix: don't allow only spaces in description
2 parents a6fca01 + 089ea71 commit 089005f

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/components/ChallengeEditor/TextEditor-Field/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class TextEditorField extends Component {
5252
readOnly={readOnly}
5353
/>
5454
</div>)}
55-
{challenge.submitTriggered && !challenge.description && (
55+
{challenge.submitTriggered && (challenge.description || '').trim().length === 0 && (
5656
<div className={styles.error}>Public Specification is required</div>
5757
)}
5858
{!readOnly && shouldShowPrivateDescription && !showShowPrivateDescriptionField && (<div className={styles.button} onClick={this.addNewPrivateDescription}>

src/components/ChallengeEditor/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,10 @@ class ChallengeEditor extends Component {
673673
const value = challenge[key]
674674

675675
// this check works for string and array values
676-
isRequiredMissing = isRequiredMissing || !value || !value.length
676+
isRequiredMissing = isRequiredMissing ||
677+
!value ||
678+
(_.isString(value) && value.trim().length === 0) ||
679+
(_.isArray(value) && value.length === 0)
677680
})
678681

679682
return !(isRequiredMissing || _.isEmpty(this.state.currentTemplate))

0 commit comments

Comments
 (0)