-
Notifications
You must be signed in to change notification settings - Fork 56
Added migration sql script: create project.templateId and new tables #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added migration sql script: create project.templateId and new tables #91
Conversation
-- projects | ||
-- | ||
ALTER TABLE projects ADD COLUMN "templateId" bigint; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about version column with default value v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about that column.
I found it in another script: https://github.com/topcoder-platform/tc-project-service/blob/feature/dev-challenges/migrations/project_add_version_column.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to remove "project_add_version_column.sql", and add the "version" column into the new script?
If so, what is the default value? v2 or v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikasrohit is it ok to have two scripts to run on prod?
-
20180608_project_add_templateId_and_new_tables.sql
-
project_add_version_column.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it is okay to have multiple scripts, I would like single script for single release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngoctay when running the scripts old records should have v2 values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngoctay I think we can merge those 2 scripts into one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
56cafd1
@coderReview