Skip to content

Added migration sql script: create project.templateId and new tables #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2018
Merged

Conversation

ngoctay
Copy link
Contributor

@ngoctay ngoctay commented Jun 8, 2018

-- projects
--
ALTER TABLE projects ADD COLUMN "templateId" bigint;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about version column with default value v2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to remove "project_add_version_column.sql", and add the "version" column into the new script?

If so, what is the default value? v2 or v3?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikasrohit is it ok to have two scripts to run on prod?

  • 20180608_project_add_templateId_and_new_tables.sql

  • project_add_version_column.sql

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it is okay to have multiple scripts, I would like single script for single release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngoctay when running the scripts old records should have v2 values.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngoctay I think we can merge those 2 scripts into one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
56cafd1

@coderReview coderReview merged commit 10cf0e1 into topcoder-platform:feature/dev-challenges Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants