Skip to content

Revert "[DEV] [HOTFIX] Kafka Topics Handlers Config" #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"pg-native": "^3.0.0",
"sequelize": "^5.8.7",
"swagger-ui-express": "^4.0.6",
"tc-core-library-js": "github:appirio-tech/tc-core-library-js#v2.6.6",
"tc-core-library-js": "github:appirio-tech/tc-core-library-js#v2.6.3",
"traverse": "^0.6.6",
"urlencode": "^1.1.0",
"yamljs": "^0.3.0"
Expand Down
94 changes: 24 additions & 70 deletions src/events/kafkaHandlers.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,18 @@
/**
* BUS Event Handlers
*/
import {
CONNECT_NOTIFICATION_EVENT,
BUS_API_EVENT,
RESOURCES,
} from '../constants';
import { CONNECT_NOTIFICATION_EVENT, BUS_API_EVENT, RESOURCES } from '../constants';
import {
projectCreatedKafkaHandler,
projectUpdatedKafkaHandler,
} from './projects';
projectUpdatedKafkaHandler } from './projects';
import { projectPhaseAddedKafkaHandler, projectPhaseRemovedKafkaHandler,
projectPhaseUpdatedKafkaHandler } from './projectPhases';
import {
timelineAdjustedKafkaHandler,
} from './timelines';
import {
projectPhaseAddedKafkaHandler,
projectPhaseRemovedKafkaHandler,
projectPhaseUpdatedKafkaHandler,
} from './projectPhases';
import { timelineAdjustedKafkaHandler } from './timelines';
import { milestoneUpdatedKafkaHandler } from './milestones';
milestoneUpdatedKafkaHandler,
} from './milestones';

const kafkaHandlers = {
/**
Expand All @@ -37,64 +33,22 @@ const kafkaHandlers = {
// Events coming from timeline/milestones (considering it as a separate module/service in future)
[CONNECT_NOTIFICATION_EVENT.MILESTONE_TRANSITION_COMPLETED]: milestoneUpdatedKafkaHandler,
[CONNECT_NOTIFICATION_EVENT.TIMELINE_ADJUSTED]: timelineAdjustedKafkaHandler,
};

/**
* Register New Unified Bus Event Handlers
*
* We need this special method so it would properly merge topics with the same names
* but different resources.
*
* @param {String} topic Kafka topic name
* @param {String} resource resource name
* @param {Function} handler handler method
*
* @returns {void}
*/
const registerKafkaHandler = (topic, resource, handler) => {
let topicConfig = kafkaHandlers[topic];

// if config for topic is not yet initialized, create it
if (!topicConfig) {
topicConfig = {};
kafkaHandlers[topic] = topicConfig;
}

if (typeof topicConfig !== 'object') {
throw new Error(
`Topic "${topic}" should be defined as object with resource names as keys.`,
);
}

if (topicConfig[resource]) {
throw new Error(
`Handler for topic "${topic}" with resource ${resource} has been already registered.`,
);
}

topicConfig[resource] = handler;
/**
* New Unified Bus Events
*/
[BUS_API_EVENT.PROJECT_CREATED]: {
[RESOURCES.PROJECT]: projectCreatedKafkaHandler,
},
[BUS_API_EVENT.PROJECT_PHASE_CREATED]: {
[RESOURCES.PHASE]: projectPhaseAddedKafkaHandler,
},
[BUS_API_EVENT.PROJECT_PHASE_UPDATED]: {
[RESOURCES.PHASE]: projectPhaseUpdatedKafkaHandler,
},
[BUS_API_EVENT.PROJECT_PHASE_DELETED]: {
[RESOURCES.PHASE]: projectPhaseRemovedKafkaHandler,
},
};

registerKafkaHandler(
BUS_API_EVENT.PROJECT_CREATED,
RESOURCES.PROJECT,
projectCreatedKafkaHandler,
);
registerKafkaHandler(
BUS_API_EVENT.PROJECT_PHASE_CREATED,
RESOURCES.PHASE,
projectPhaseAddedKafkaHandler,
);
registerKafkaHandler(
BUS_API_EVENT.PROJECT_PHASE_UPDATED,
RESOURCES.PHASE,
projectPhaseUpdatedKafkaHandler,
);
registerKafkaHandler(
BUS_API_EVENT.PROJECT_PHASE_DELETED,
RESOURCES.PHASE,
projectPhaseRemovedKafkaHandler,
);


export default kafkaHandlers;