Skip to content

Disabling the special permission check for billing account id updates #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020
Merged

Disabling the special permission check for billing account id updates #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/routes/projects/update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ const validateUpdates = (existingProject, updatedProps, req) => {
!util.hasPermissionByReq(PERMISSION.MANAGE_PROJECT_DIRECT_PROJECT_ID, req)) {
errors.push('You do not have permission to update \'directProjectId\' property');
}
if (_.has(updatedProps, 'billingAccountId') &&
!util.hasPermissionByReq(PERMISSION.MANAGE_PROJECT_BILLING_ACCOUNT_ID, req)) {
errors.push('You do not have permission to update \'billingAccountId\' property');
}
// if (_.has(updatedProps, 'billingAccountId') &&
// !util.hasPermissionByReq(PERMISSION.MANAGE_PROJECT_BILLING_ACCOUNT_ID, req)) {
// errors.push('You do not have permission to update \'billingAccountId\' property');
// }
if ((existingProject.status !== PROJECT_STATUS.DRAFT) && (updatedProps.status === PROJECT_STATUS.DRAFT)) {
errors.push('cannot update a project status to draft');
}
Expand Down
2 changes: 1 addition & 1 deletion src/routes/projects/update.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ describe('Project', () => {
});
});

it('should return 400 when updating billingAccountId without "write:projects-billing-accounts" scope in M2M token',
xit('should return 400 when updating billingAccountId without "write:projects-billing-accounts" scope in M2M token',
(done) => {
request(server)
.patch(`/v5/projects/${project1.id}`)
Expand Down