Fix for Issue #561 Return empty invites for user without enough permission

[gets0ul]

• use separate scope for invites
• return project with empty invites if user doesn't have enough permission

[maxceem]

@gets0ul works good.

The only thing we have to find invites by email in a case-insensitive way, but I guess thee lines wouldn't fine invite if user is invited with email in different case than in user profile.

_.filter(fp.invites, invite => invite.userId === currentUserId || invite.email === email);

[gets0ul]

@maxceem PR is updated

[maxceem]

@gets0ul some lint errors are there, and I guess there is a misuse of email and currentUserEmail

[gets0ul]

@maxceem fixed.

[maxceem]

Works good now @gets0ul.

Actually, we also have to filter invites when we get the from DB in the project list endpoint, not only ES, but it's better to handle it a little bit letter due to other changes we did in develop branch.

[vikasrohit]

@maxceem I am pretty much sure that we have taken care of this but just want to be double sure, this change would not cause problem in returning invites for a user is invited to the project.

[maxceem]

@maxceem I am pretty much sure that we have taken care of this but just want to be double sure, this change would not cause problem in returning invites for a user is invited to the project.

Yes, we took care of it. And it's already deployed to DEV. So I guess during QA someone would notice if it accidentally got broken somehow. But as it's important functionality I would ask QA team to make regression testing here appirio-tech/connect-app#4019.