Skip to content

connect-app#3755 Fix searching projects by handle to be case insensitive. #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2020
Merged

connect-app#3755 Fix searching projects by handle to be case insensitive. #501

merged 1 commit into from
Mar 12, 2020

Conversation

gets0ul
Copy link
Contributor

@gets0ul gets0ul commented Mar 10, 2020

@gets0ul gets0ul mentioned this pull request Mar 10, 2020
Closed
maxceem
maxceem approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thank you for comprehensive test @gets0ul.

If I put back `index: 'not_analyzed', then I can see that tests are failing, which means the reason for the searching issue is correct and tests detect it:

image

@maxceem maxceem merged commit 6f8eda7 into topcoder-platform:cf21 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gets0ul @maxceem