Skip to content

#488 Project List endpoint returns member email for some projects #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Feb 27, 2020

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution It works good now for project members, though fields should be fixed in general for all the fields. And there are some issues for other fields:

  1. In LIST endpoint, when I only request fields=id, LIST endpoint still returns phases and invites:

    image

  2. In GET endpoint, when I only request fields=id, there are still invites are returned:

    image

  3. In GET and LIST endpoints all the fields are always returned for invites even if I define only some fields:

    image

    image

  4. In GET and LIST endpoints if I try to get only some fields for attachments then attachments are not retunred at all:

    image

    but

    image

Please, create unit tests to verify all the issues listed above so we are sure they are fixed.

@maxceem
Copy link
Contributor

maxceem commented Feb 28, 2020

@yoution btw, we pushed a big update the master branch, please, use the updated master branch. You may merge the updated master branch into your branch.

@yoution yoution requested a review from maxceem February 28, 2020 11:01
@maxceem maxceem changed the base branch from master to hotfix/post-release-2.1.1 March 2, 2020 03:45
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works great now. Thanks, @yoution.

@maxceem maxceem merged commit 275d8da into topcoder-platform:hotfix/post-release-2.1.1 Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants