Skip to content

Add reports tests #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2020
Merged

Add reports tests #486

merged 2 commits into from
Feb 25, 2020

Conversation

xxcxy
Copy link
Contributor

@xxcxy xxcxy commented Feb 25, 2020

No description provided.

@maxceem maxceem changed the base branch from develop to feature/report-improvements February 25, 2020 05:38
maxceem
maxceem suggested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xxcxy looks like unit tests don't detect errors.

If I broke the code so it returns wrong error codes 401 instead of 400 and 501 instead of 500:
image

and

image

All unit tests still pass, though tests like should return 404... and should return 500... suppose to fail.

maxceem
maxceem approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good now.

@maxceem maxceem merged commit effc885 into topcoder-platform:feature/report-improvements Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxcxy @maxceem