Skip to content

[HOTIFX] [DEV] [2.0.3] Don't return email in invites #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

[HOTIFX] [DEV] [2.0.3] Don't return email in invites #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,17 @@ _.assignIn(util, {
return _.map(members, (member) => {
let memberDetails = _.find(allMemberDetails, ({ userId }) => userId === member.userId);
memberDetails = _.assign({}, member, memberDetails);
// this case would be only valid for invites:
// don't return `email` for non-admins if invitation has `userId`
// if invitation doesn't have `userId` means it is invitation by email
// then we are still returning emails to all users
if (
memberDetails.email &&
memberDetails.userId &&
!util.hasPermission({ topcoderRoles: ADMIN_ROLES }, req.authUser)
) {
delete memberDetails.email;
}
return _(memberDetails).pick(fields).defaults(memberDefaults).value();
});
},
Expand Down