Skip to content

New Fields for Project Templates #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

New Fields for Project Templates #436

merged 1 commit into from
Jan 9, 2020

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Jan 8, 2020

maxceem
maxceem approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been reviewed during the challenge and works great.

@maxceem
Copy link
Contributor

maxceem commented Jan 9, 2020 •
edited
Loading

@vikasrohit this PR is to add additional fields to the Project Template model, so we can implement the Project Catalog Redesign.

It has been tested during the challenge and works great.

To merge this PR we also have to apply SQL migration script https://github.com/topcoder-platform/tc-project-service/pull/436/files#diff-ef9223f9c9a99f20406a4563df19562b so I cannot merge this OR by myself.

As soon as we merge this PR we can merge PR for project-processor-es topcoder-platform/project-processor-es#16.
And after that, we can merge PR to the Connect App appirio-tech/connect-app#3487.

@maxceem maxceem requested a review from vikasrohit January 9, 2020 03:09
vikasrohit
vikasrohit approved these changes Jan 9, 2020
View reviewed changes
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit vikasrohit merged commit 9c4f5ac into topcoder-platform:develop Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxceem maxceem maxceem approved these changes

@vikasrohit vikasrohit vikasrohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoution @maxceem @vikasrohit