Skip to content

implement new roles #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Sep 26, 2019
Merged

implement new roles #383

merged 2 commits into from Sep 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2019

Note:

  • Connect Account Manager equivalent user roles will be called CAM~
    “Business Development Representative”, “Presales”, “Account Executive”
  • Connect Manager equivalent user roles will be called CM~
    “Program Manager”, “Solution Architect”, “Project Manager”

Test Acceptances:

  • CAM~ or CM~ can activate scope change
  • CAM~ or CM~ can see budget and budget spent in report
  • CAM~ or CM~ can access invoice report
  • User role cannot be updated to CAM~ or CM~ roles
  • CM~ can delete project member
  • CM~ can delete project
  • CM~ can add project member directly
  • CAM~ or CM~ can transition project status to 'active'
  • CM~ can edit project plan
  • CM~ and CAM~ can invite topcoder member
  • CM~ can access private post

Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vikasrohit vikasrohit merged commit 4b7336f into topcoder-platform:feature/new-roles Sep 26, 2019
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fikzzzy looks great. There are only a couple places I have concerns about.

  1. I think we also have to let new project "manager" roles to switch project status to active https://github.com/topcoder-platform/tc-project-service/blob/feature/new-roles/src/routes/projects/update.js#L223

USER_ROLE.MANAGER,
USER_ROLE.TOPCODER_ACCOUNT_MANAGER,
USER_ROLE.BUSINESS_DEVELOPMENT_REPRESENTATIVE,
USER_ROLE.PRESALES,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fikzzzy it looks like we have to add to this list all new USER_ROLES. As before we had there both USER_ROLE.MANAGER and USER_ROLE.TOPCODER_ACCOUNT_MANAGER.

])) {
const err = new Error(
`Only manager, account manager, business development representative,
or presales are able to join as ${targetRole}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fikzzzy if we add more roles above, we also have to update this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants