Skip to content

Feature/project product templates final fixes #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2019
Merged

Feature/project product templates final fixes #298

merged 4 commits into from
Apr 30, 2019

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Apr 30, 2019

Fixes for issue #296:

  • reuse function checkModel
  • improved validation

@maxceem maxceem requested a review from vikasrohit April 30, 2019 02:30
vikasrohit
vikasrohit approved these changes Apr 30, 2019
View reviewed changes
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit vikasrohit merged commit 40628db into dev Apr 30, 2019
@vikasrohit vikasrohit deleted the feature/project-product-templates-final-fixes branch July 29, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasrohit vikasrohit vikasrohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxceem @vikasrohit @mfikria