Skip to content

Limit draft phase update events to topcoder project members #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

gondzo
Copy link
Collaborator

@gondzo gondzo commented Feb 9, 2019

@vikasrohit this one fixes topcoder-platform/tc-notifications#85
we'll limit the notifications only to topcoder team if phase is not visible to customer (draft)

@vikasrohit
Copy link

vikasrohit commented Feb 11, 2019

Thank @gondzo It seems like we are still generating the events but just trying to hide them on front end by looking at allowedUser field?

@gondzo
Copy link
Collaborator Author

gondzo commented Feb 11, 2019

generating events - yes
generating notifications - only for users in allowedUsers list (no need to filter in connect-app or emails)

@vikasrohit
Copy link

generating notifications - only for users in allowedUsers list

Did I miss the changes in tc-notifications then?

@gondzo
Copy link
Collaborator Author

gondzo commented Feb 11, 2019

@vikasrohit
Copy link

Ohk. Got it.

@vikasrohit
Copy link

@vikasrohit vikasrohit merged commit 5a001a8 into dev Feb 11, 2019
@vikasrohit
Copy link

@gondzo I have patched (topcoder-platform/tc-notifications@d1eefb9) the tc-notifications to use string instead of variable name for the issue mentioned above, let me know if you think that is not a desired change.

@vikasrohit vikasrohit deleted the feature/PhaseEventPermissions branch July 29, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase updates
2 participants