Skip to content

Ignoring the missing member details for new project creation to reduce the number of errors on production and reduce the customer loss #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Ignoring the missing member details for new project creation to reduce the number of errors on production and reduce the customer loss #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/events/projects/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ const indexProject = Promise.coroutine(function* (logger, msg) { // eslint-disab
// retrieve member details
const memberDetails = yield util.getMemberDetailsByUserIds(userIds, msg.properties.correlationId, logger);
// if no members are returned than this should result in nack
if (!_.isArray(memberDetails) || memberDetails.length === 0) {
logger.error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
throw new Error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
}
// if (!_.isArray(memberDetails) || memberDetails.length === 0) {
// logger.error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
// throw new Error(`Empty member details for userIds ${userIds.join(',')} requeing the message`);
// }
// update project member record with details
data.members = data.members.map((single) => {
const detail = _.find(memberDetails, md => md.userId === single.userId);
Expand Down