Production release to support Connect 2.4.4 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed PATCH endpoint to allow specifying only fields to be updated
…as because we were sending response before transaction commit. Fixed the same for milestone template as well and for update endpoints for milestone and milestone template as well. Made fields in update call to milestone endpoint, optional so that user can specify only sub set of the fields to be updated.
…api_base_url_and_phase_msg_text Hotfix/fixing message api base url and phase msg text
— Added logic to handle the product as reference for timeline
…estone. - Should be fixed now
…nes together — Implemented the functionality by reading the templateId instead of reading the milestones in the request body. This would make things consistent with the way we are handling project and phases.
— Fixed permission logic for milestones
…efore transaction commit which is causing significant extra time for the transaction to complete which in turn causing other operations of the same table to fail because of table locks.
…reate and Update were fixed previously.
…fixed before and update is not using transactions as of now which is a separate issue to fix.
- Added connectProjectsUrl config var to test.json, as it's needed for running tests.
… api. - Added connectProjectsUrl config var to test.json, as it's needed for running tests.
…Date, endDate and duration.
added 29 commits
August 1, 2018 11:18
…unnecessary calls
…ading the changes in a milestone - Should be fixed now
…encoded query params — Should be fixed
… when they are updated via cascaded changes
Removed code to recalculate the order of the milestones for ES indexing, now it should be carrying those changes to the ES via cascaded updates
…f milestone is changed.
…active earlier or later than its scheduled start
…e and endDate so that we can pass them without each other
…tone Feature/timeline milestone
…n be decoupled in upcoming releases from products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Adds support timelines and milestones
-- Adds support for milestone templates
-- Supports metadata in projectType model so that other services can use that to store additional data specific to that application for each project type e.g. tc-connect-notifications needs this to store colors for each project type
fyi @acshields @RishiRajSahu @mtwomey , I am going to deploy this on production today without much downtime.