Skip to content

Issue #126 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Issue #126 #154

merged 2 commits into from
Jul 31, 2018

Conversation

architectt1
Copy link
Contributor

  • Fixed issue where identical data were being treated as different and then triggering milestones' updates.
  • Do not trigger milestones' updates if the timeline endDate changed.
  • Added comments to milestones' updates when a timeline gets updated.

…d then triggering milestones' updates.

- Do not trigger milestones' updates if the timeline endDate changed.
- Added comments to milestones' updates when a timeline gets updated.
@architectt1 architectt1 requested a review from vikasrohit July 30, 2018 23:58
@architectt1 architectt1 added the bug-bash To collect all tasks for a bug bash label Jul 31, 2018
@vikasrohit
Copy link

Thanks @architectt1

Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit vikasrohit merged commit 001ef29 into feature/timeline-milestone Jul 31, 2018
@vikasrohit vikasrohit deleted the issue/126 branch August 29, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-bash To collect all tasks for a bug bash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants