Added more bus api events #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architectt1
force-pushed
the
feature/newEvents
branch
from
185e450 to
cbfaebf
Compare
vikasrohit
reviewed
Aug 23, 2018
src/constants.js
Outdated
| @@ -61,6 +61,12 @@ export const BUS_API_EVENT = { | |||
| PROJECT_CANCELED: 'notifications.connect.project.canceled', | |||
| PROJECT_ACTIVE: 'notifications.connect.project.active', | |||
|
|
|||
| PROJECT_PHASE_TRANSITION_ACTIVE: 'project.phase.transition.active', | |||
There was a problem hiding this comment.
@architectt1 @gondzo I think we need to keep notifications.connect as prefix for all new events as well.
There was a problem hiding this comment.
agreed, I'll push the change shortly
|
looks like a bug. agreed on the isEqual change. |
|
Could you please do that change in this same PR @gondzo? I haven't checked out the the architectt1's origin yet. Also, seems like their is conflict as well, which needed to be resolved before merging. After these changes, I think we are safe to merge this PR into dev. |
|
@gondzo, resolved conflict, merging the PR to reduce the number of things in flight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All events are sent when needed.