Skip to content

[$100] Make sure transactions work automatically #323

Closed
@maxceem

Description

@maxceem

As we use continuation-local-storage for Sequelize transactions should work without direct passing the transaction object into the options. And we use this in many places in the project:

image

Though as per my testings, it feels that transactions didn't work (partials changes weren't reverted in case something failed). But it might be some other reasons as I could make several fixes at once as I was sure that it wouldn't work without directly defining transactions. So as a result in new changes done in this PR #322 I forced passing transactions explicitly:

image

Todo

  1. Make sure that transactions work without explicit passing as we are using continuation-local-storage for Sequelize, see docs.

  2. Update code to NOT pass transactions explicitly.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions