Closed
Description
As we use continuation-local-storage
for Sequelize
transactions should work without direct passing the transaction
object into the options
. And we use this in many places in the project:
Though as per my testings, it feels that transactions didn't work (partials changes weren't reverted in case something failed). But it might be some other reasons as I could make several fixes at once as I was sure that it wouldn't work without directly defining transactions. So as a result in new changes done in this PR #322 I forced passing transactions explicitly:
Todo
-
Make sure that transactions work without explicit passing as we are using
continuation-local-storage
forSequelize
, see docs. -
Update code to NOT pass transactions explicitly.