[$120] Don't let invite user by email if he is already in the team or already invited

[maxceem]

Actual behaviour

Example, I'm already is a Manager in Topcoder team of this project https://connect.topcoder-dev.com/projects/7709

I invite myself to the Project Team using email my address and server accepts my requests and creates an invitation.

After I reload the page I got invitation popup even though I'm already in the Topcoder team.

If I click Join Project I would get error that I'm already in the team.

Expected behaviour

When we invite user by email which is already in the Topcoder or Project Team, server should reject such request, don't create invitation and return an error, that a user with such an email is already in the team.

This issue is somehow connected with #233

fyi @RishiRajSahu

[vikasrohit]

@maxceem I think this one does not exist any more. Let me know if we can close this.

[vikasrohit]

@maxceem can we close this?

[maxceem]

@vikasrohit I think this is fixed client-side so this issue would never happen in the real life, but it's not fixed server-side.

[vikasrohit]

Okay, then we should get it implemented in backend as well. Marking this issue for 2.4.13 release. I am thinking of a quick bug bash for that milestone.

[maxceem]

Note we can invite several members at once, using handles and emails. When we invite user which is already in the team we have to return emails, for which invitations are failed in the response inside failed property, the same we do now for other errors. While successful invitation should be created as now.

See we return failed property if there are any invitations failed https://github.com/topcoder-platform/tc-project-service/blob/cf18/src/routes/projectMemberInvites/create.js#L292

See an example, where we populate such the failed list: https://github.com/topcoder-platform/tc-project-service/blob/cf18/src/routes/projectMemberInvites/create.js#L124

For the error message use the next text: User with such email is already a member of the team..

We should create a unit test to validate this case.

[romitgit]

Please assign this issue to me

[maxceem]

@romitgit assigned.
To setup project locally you would need to set some environment variables as per README, you can find them on the forum of the challenge.

[romitgit]

@maxceem thanks. Will look into that.

[maxceem]

Thanks, just would like to remind that as per our Bug Bash rules, the submission PR should be created during 12 hours, or issues may be unassigned.