Removing hidden templates from the metadata call

[RishiRajSahu]

Currently, all the project templates gets fetched during metadata call. Changes needs to be done on to filter away the hidden templates from the metadata endpoint.

fyi @vikasrohit

[vikasrohit]

This has to be done for non admin users only. Admin users should still be able to fetch all templates and metadata.

[maxceem]

@RishiRajSahu I just want to confirm that we really want to do this.

Currently, we don't let user choose hidden templates during project creation, but they still can navigate to them using direct link. In the Connect app we load all the metadata once and after we treat all metadata as loaded to the redux store. If we don't return hidden templates anymore, we should update the Connect app for the next cases:

1. In case we try to use the direct link, Connect app should try to load the requests template directly as it would be not loaded in the redux store.
2. When we open project now, we expect that template is already loaded into the redux store, so when we open project which has been created with a hidden template, we should additionally make sure that template is loaded, and if no - load it.

On the other hand, we should never return disabled templates not in /metadata requests nor by the direct link for non-admins, as such templates cannot be used in any way. But we still should return them to admin users. I can see that it is already done, but disabled templates now are not returned to admin users also, so admin users cannot see them listed in the metadata editor.

I guess the next rules should be applied to all the templates:

Prop	Endpoint	User	Return
hidden	metadata, list	non-admin	no
hidden	get	non-admin	yes
hidden	metadata, list, get	admin	yes
disabled	metadata, list, get	non-admin	no
disabled	metadata, list, get	admin	yes

Note, as we return to admins disabled templates, we should make sure that admin cannot create projects with such template client-side, otherwise, if other users would try to open such templates they would get an error.

[vikasrohit]

hidden | metadata, list, get | admin | yes

I guess, even for admins, we don't need metadata endpoint to return hidden templates.

Note, as we return to admins disabled templates, we should make sure that admin cannot create projects with such template client-side, otherwise, if other users would try to open such templates they would get an error.

May be we can show a warning on top of the project or near the submit button, which is shown only for admins and for disabled templates only.