Skip to content

Commit be61078

Browse files
committed
fix: unit tests
1 parent ce4d281 commit be61078

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

src/routes/projects/get.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ describe('GET Project', () => {
526526
});
527527
});
528528

529-
it('should not return "email" for any invite which has userId field', (done) => {
529+
it('should not return "userId" for any invite which has "email" field', (done) => {
530530
request(server)
531531
.get(`/v5/projects/${project1.id}`)
532532
.set({
@@ -541,8 +541,8 @@ describe('GET Project', () => {
541541
const resJson = res.body;
542542
should.exist(resJson);
543543
resJson.invites.length.should.be.eql(1);
544-
resJson.invites[0].should.have.property('userId');
545-
should.not.exist(resJson.invites[0].email);
544+
resJson.invites[0].should.have.property('email');
545+
should.not.exist(resJson.invites[0].userId);
546546
done();
547547
}
548548
});

src/routes/projects/list.spec.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -382,10 +382,6 @@ describe('LIST Project', () => {
382382
const resJson = res.body;
383383
should.exist(resJson);
384384
resJson.should.have.lengthOf(2);
385-
resJson[0].invites[0].should.have.property('userId');
386-
should.not.exist(resJson[0].invites[0].email);
387-
resJson[1].invites[0].should.have.property('userId');
388-
should.not.exist(resJson[1].invites[0].email);
389385
done();
390386
}
391387
});
@@ -1081,8 +1077,8 @@ describe('LIST Project', () => {
10811077
resJson.should.have.lengthOf(1);
10821078
resJson[0].name.should.equal('test1');
10831079
resJson[0].invites.should.have.lengthOf(2);
1084-
resJson[0].invites[0].should.have.property('userId');
1085-
should.not.exist(resJson[0].invites[0].email);
1080+
resJson[0].invites[0].should.have.property('email');
1081+
should.not.exist(resJson[0].invites[0].userId);
10861082
resJson[0].invites[1].email.should.equal('h***o@w***d.com');
10871083
done();
10881084
}

src/util.spec.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,22 +190,24 @@ describe('Util method', () => {
190190
util.postProcessInvites('$.invites[?(@.email)]', detail, res).should.deep.equal(detail2);
191191
});
192192

193-
it('should not return emails for invite with defined userId', () => {
193+
it('should not return `userId` for invite by email', () => {
194194
const detail = {
195195
id: 1,
196196
invites: [{
197197
id: 2,
198198
email: 'abcd@aaaa.com',
199199
userId: 33,
200+
createdBy: 2,
200201
},
201202
],
202203
};
203204
const detail2 = {
204205
id: 1,
205206
invites: [{
206207
id: 2,
207-
email: null,
208-
userId: 33,
208+
email: 'abcd@aaaa.com',
209+
userId: null,
210+
createdBy: 2,
209211
},
210212
],
211213
};

0 commit comments

Comments
 (0)