Skip to content

Commit ce4d281

Browse files
committed
Merge branch 'develop' into feature/restful-invites
# Conflicts: # src/util.js
2 parents 7229cfc + 44a8a0b commit ce4d281

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

src/events/projects/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const eClient = util.getElasticSearchClient();
2323
*/
2424
const indexProject = Promise.coroutine(function* (logger, msg) { // eslint-disable-line func-names
2525
const data = JSON.parse(msg.content.toString());
26-
const userIds = data.members ? data.members.map(single => `userId:${single.userId}`) : [];
26+
const userIds = data.members ? _.map(data.members, 'userId') : [];
2727
try {
2828
// retrieve member details
2929
const memberDetails = yield util.getMemberDetailsByUserIds(userIds, logger, msg.properties.correlationId);
@@ -197,7 +197,9 @@ async function projectUpdatedKafkaHandler(app, topic, payload) {
197197
// first get the existing document and than merge the updated changes and save the new document
198198
try {
199199
const doc = await eClient.get({ index: ES_PROJECT_INDEX, type: ES_PROJECT_TYPE, id: previousValue.id });
200+
console.log(doc._source, 'Received project from ES');// eslint-disable-line no-underscore-dangle
200201
const merged = _.merge(doc._source, project.get({ plain: true })); // eslint-disable-line no-underscore-dangle
202+
console.log(merged, 'Merged project');
201203
// update the merged document
202204
await eClient.update({
203205
index: ES_PROJECT_INDEX,
@@ -207,6 +209,7 @@ async function projectUpdatedKafkaHandler(app, topic, payload) {
207209
doc: merged,
208210
},
209211
});
212+
console.log(`Succesfully updated project document in ES (projectId: ${previousValue.id})`);
210213
} catch (error) {
211214
throw Error(`failed to updated project document in elasitcsearch index (projectId: ${previousValue.id})` +
212215
`. Details: '${error}'.`);

src/routes/admin/project-index-create.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ module.exports = [
6969
// check context for project members
7070
project.members = _.map(currentProjectMembers, m => _.pick(m, fields.project_members));
7171
logger.debug('project.members => ', project.members);
72-
const userIds = project.members ? project.members.map(single => `userId:${single.userId}`) : [];
72+
const userIds = project.members ? _.map(project.members, 'userId') : [];
7373
logger.debug('userIds => ', userIds);
7474
return util.getMemberDetailsByUserIds(userIds, logger, req.id)
7575
.then((memberDetails) => {

src/routes/projectMemberInvites/create.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ const sendInviteEmail = (req, projectId, invite) => {
201201
where: { id: projectId },
202202
raw: true,
203203
}),
204-
util.getMemberDetailsByUserIds([`userId:${req.authUser.userId}`], req.log, req.id),
204+
util.getMemberDetailsByUserIds([req.authUser.userId], req.log, req.id),
205205
];
206206
return Promise.all(promises).then((responses) => {
207207
req.log.debug(responses);

src/services/lookerService.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ function generateEmbedUrl(authUser, project, member, reportUrl) {
110110
group_ids: [],
111111
first_name: member.firstName,
112112
last_name: member.lastName,
113-
permissions: ['access_data', 'see_looks', 'see_user_dashboards'],
113+
permissions: ['access_data', 'see_looks', 'see_user_dashboards', 'schedule_look_emails', 'download_with_limit'],
114114
models: ['projects_tc_employees'],
115115
access_filters: {
116116
projects_tc_employees: {

0 commit comments

Comments
 (0)