Email templates rendering update #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly rendering of both individual and bundled notifications by using partials and a master template.
…hub.com/topcoder-platform/tc-notifications into architectt1-feature/emailTemplatesClean
Fixed the default value of the CONNECT_URL to not include the www
…that we can trigger an alert.
— Assumed 24 hour bundling for all new events which we are supporting in email. This excludes the messaging events from bundling by default, if user has opted for bundling for messaging events, they would continue to receive the bundled emails.
|
@gondzo I am going to merge this PR in dev by today EOD. Let me know if you think we still need some missing pieces before merging this. |
added 4 commits
September 19, 2018 17:07
added 2 commits
September 26, 2018 20:46
Clean up of email action bus events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging:
CONNECT_URLenvironment variable (defaults tohttp://www.connect.topcoder-dev.com)notifications.action.email.connect.project.specificationModifiedtopicTODO:
add email content for phases&milesones