m2m token #26
Merged
m2m token #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v2.3 tag created in tc-core-lib-js |
|
agreed. I think member service changes won't go into prod in the next few days, so let's wait with merging this one |
added 7 commits
April 30, 2018 11:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses m2m token to call member service instead of hardcoded admin token
before merging, tag v2.3 has to be created in https://github.com/appirio-tech/tc-core-library-js/tree/dev-auth0
before deployment, these env vars have to be defined auth0Audience, tokenCacheTime, auth0CliendId, auth0CliendSecret
@vikasrohit is it ok to merge this before discourse migration branch gets to dev/prod ?