Skip to content

Community Notifications Changes (prod) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 23, 2020
Merged

Community Notifications Changes (prod) #184

merged 15 commits into from
Mar 23, 2020

Conversation

sachin-maheshwari
Copy link
Contributor

Covers following issue/features -

  • Avoid multiple calls for member api and group api
  • Fix for duplicate notifications (challenge api)
  • Stopping notification for "A new submission is uploaded" events (submission.notification.create)
  • Changes as per described at Checkpoint Review Notification community-app#4114
  • Public group logic changes - now excluding group like ["!CS", "!Zurich", "!Topgear"]

Sachin Maheshwari and others added 15 commits March 13, 2020 13:23
caching member api call
bfaccec
fixing multiple member and group calls and duplicate user notifications
faff5fe
fixing typo
d70c9ee
as per request at git-issue topcoder-platform/community-app#4108, dis…
ae649d2 
…abling events 'A new submission is uploaded'
Changes according to topcoder-platform/community-app#4114
8d42c73
changes in public group logic so that only some groups should not get…
75ff36e 
… public messasge as per slack discussion - https://app.slack.com/client/T03R80JP7/CG2J9RH70/thread/CG2J9RH70-1583899598.019100
fixing typo
73671a8
typo
c5f45e5
setting one(topic) to many processor(handlers)
4c5f800
correcting message
533397f
@maxceem
chore: remove redundant "emailBundling"
98ebc42
Merge branch 'dev' into bug/rate-limit
1026ba6
logical error in checking exclude group
1e8cd5a
correcting logical error in checking exclude group
4ba2b87
Merge pull request #183 from topcoder-platform/bug/rate-limit
899da23 
Community Notifications Changes
@sachin-maheshwari
Copy link
Contributor Author

@maxceem can i take your changes for Production (planning next week) ?

@maxceem
Copy link
Contributor

maxceem commented Mar 19, 2020

@sachin-maheshwari yes, I've just removed a redundant constant which we don't use anymore, to keep it clear, as per appirio-tech/connect-app#3505

@sachin-maheshwari
Copy link
Contributor Author

@maxceem 👍

@sachin-maheshwari sachin-maheshwari merged commit 0ded256 into master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachin-maheshwari @maxceem