Issue #1469 - User mentions in the posts #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
passimm
commented
Jan 10, 2018
passimm
commented
- detail: extract @userid from post and send notification to each @userid
|
looks good. one minor item: we should use a new notification type for this one: notifications.connect.project.post.mention so it doesn't clash with the existing post.created notification. can you just add notification.type='notifications.connect.project.post.mention' at connectNotificationServer.js#72 and update src/app.js#55 to |
detail: 1. add new event type notifications.connect.project.post.mention 2. extract mentions(like @userid) notifications.connect.project.post.create's content, and send mention notification to users
passimm
force-pushed
the
handle_notification
branch
from
6c03788 to
10b0c98
Compare
passimm
force-pushed
the
handle_notification
branch
from
b85db42 to
b9dea0d
Compare
|
@gondzo updated per your comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.