PM-1201 - sync payments with legacy #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vas3a
commented
May 20, 2025
| ), | ||
| ); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| if (transactions.length > 0) { |
There was a problem hiding this comment.
FYI - needed to update the way the DBtransaction is handled from batch transactions to one big transaction in order to be able to fail the transaction if the legacy update failed (this is happening only for admin updates only, for withdraw, we're just logging the error).
| } | ||
|
|
||
| const payoutData: AdminPaymentUpdateData = { | ||
| userId: +winning.winner_id, |
There was a problem hiding this comment.
high
correctness
Ensure that winning.winner_id is always a valid number before using the unary plus (+) operator for type coercion. If winning.winner_id can be null or undefined, this could lead to unexpected results. Consider adding validation or a default value to handle such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-1201 - Sync payment status to legacy/Informix