upgrade node and coding style #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hamidre13
commented
Sep 6, 2022
hamidre13
commented
- Convert from callback and promise to async/await,
- Upgrade all the node module packages to the latest version
Convert from callback and promise to asyc/await, upgrade all the node module packages to the latest version
|
@Gunasekar-K @ThomasKranitsas would you review my changes? I do like to know your input before cleaning up and submitting the final changes. |
|
There are some conflicts, wanna resolve the conflicts and then I'll do a final review? Right now, it looks good by just looking at the code, though, I haven't ran it yet |
|
@eisbilir @ThomasKranitsas Please let me know when you get a chance to review this branch. |
hamidre13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.