Decoupling sendgrid template id from Kafka topic #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'sendgrid_template_id' in payload
…idtemplateid Allowing sendgrid template id in payload
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.10...4.17.13) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.14.0. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.12.0...3.14.0) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com>
…/eslint-utils-1.4.3 Bump eslint-utils from 1.3.1 to 1.4.3
…/js-yaml-3.14.0 Bump js-yaml from 3.12.0 to 3.14.0
…/lodash-4.17.13 Bump lodash from 4.17.10 to 4.17.13
Bumps [sequelize](https://github.com/sequelize/sequelize) from 4.32.2 to 5.15.1. - [Release notes](https://github.com/sequelize/sequelize/releases) - [Commits](sequelize/sequelize@v4.32.2...v5.15.1) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.1 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.1...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>
…/sequelize-5.15.1 Bump sequelize from 4.32.2 to 5.15.1
Bumps [extend](https://github.com/justmoon/node-extend) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/justmoon/node-extend/releases) - [Changelog](https://github.com/justmoon/node-extend/blob/main/CHANGELOG.md) - [Commits](justmoon/node-extend@v3.0.1...v3.0.2) Signed-off-by: dependabot[bot] <support@github.com>
…/acorn-5.7.4 Bump acorn from 5.7.1 to 5.7.4
…/extend-3.0.2 Bump extend from 3.0.1 to 3.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is 1 to 1 mapping of kafka topic name and sendgrid template id.
This changes will allow one Kafka topic can be used for multiple sendgrid templates. Now user can send sendgrid template-id in payload (Kafka-Message). Also can overwrite the existing template-id by sending in payload.