Skip to content

V5 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 29, 2018
Merged

V5 #18

merged 12 commits into from
Jun 29, 2018

Conversation

cwdcwd
Copy link
Contributor

@cwdcwd cwdcwd commented Jun 25, 2018

No description provided.

@cwdcwd cwdcwd requested a review from sachin-maheshwari June 25, 2018 21:24
@sachin-maheshwari
Copy link
Contributor

@cwdcwd
Copy link
Contributor Author

cwdcwd commented Jun 27, 2018

@sachin-maheshwari would it be that we need to config some env vars? I see Swagger-ui is available on http://localhost:3000/docs before that error line which seems wrong

@sachin-maheshwari
Copy link
Contributor

@cwdcwd yes, if you are setting-up locally, you need some env vars. You can refer dev for same - https://console.aws.amazon.com/ecs/home?region=us-east-1#/taskDefinitions/tc-bus-api-task/82

@sachin-maheshwari
Copy link
Contributor

@cwdcwd Looks like my testing "timestamp" was wrong. I am trying to deploy on Dev and check again.

@sachin-maheshwari
Copy link
Contributor

@cwdcwd its working fine. There was validation issue. Further I'll verify more once we fix the old format bus payload changes in down stream services i.e. tc-project and tc-message.

@cwdcwd
Copy link
Contributor Author

cwdcwd commented Jun 29, 2018

thanks @sachin-maheshwari !

@callmekatootie
Copy link
Collaborator

@cwdcwd Added auth checks

@cwdcwd cwdcwd merged commit 8a89a98 into dev Jun 29, 2018
@hamidre13 hamidre13 deleted the v5 branch September 13, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants