Skip to content

[PROD] Next Release #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ workflows:
branches:
only:
- dev
- dev-circleci
- feature/shapeup4-cqrs-update2

# Production builds are exectuted only on tagged commits to the
# master branch.
Expand Down
77 changes: 43 additions & 34 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@
"superagent": "^5.1.0"
},
"dependencies": {
"@hapi/joi": "^15.1.0",
"@joi/date": "^2.1.0",
"async-mutex": "^0.2.4",
"bluebird": "^3.5.5",
"config": "^3.1.0",
"dotenv": "^10.0.0",
"get-parameter-names": "^0.3.0",
"joi": "^17.4.2",
"lodash": "^4.17.20",
"no-kafka": "^3.4.3",
"tc-core-library-js": "^2.4.1",
Expand Down
3 changes: 2 additions & 1 deletion src/bootstrap.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const Joi = require('@hapi/joi')
const Joi = require('joi')
const config = require('config')
const constants = require('./common/constants')

Expand All @@ -8,6 +8,7 @@ Joi.rateType = () => Joi.string().valid('hourly', 'daily', 'weekly', 'monthly',
Joi.jobStatus = () => Joi.string().valid('sourcing', 'in-review', 'assigned', 'closed', 'cancelled')
Joi.jobCandidateStatus = () => Joi.string().valid('open', 'placed', 'selected', 'client rejected - screening', 'client rejected - interview', 'rejected - other', 'cancelled', 'interview', 'topcoder-rejected', 'applied', 'rejected-pre-screen', 'skills-test', 'skills-test', 'phone-screen', 'job-closed', 'offered', 'withdrawn', 'withdrawn-prescreen')
Joi.workload = () => Joi.string().valid('full-time', 'fractional')
Joi.jobTag = () => Joi.string().valid('New', '$$$', 'Hot').allow('')
Joi.title = () => Joi.string().max(128)
// Empty string is not allowed by Joi by default and must be enabled with allow('').
// See https://joi.dev/api/?v=17.3.0#string fro details why it's like this.
Expand Down
2 changes: 1 addition & 1 deletion src/common/logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/

const _ = require('lodash')
const Joi = require('@hapi/joi')
const Joi = require('joi')
const util = require('util')
const config = require('config')
const getParams = require('get-parameter-names')
Expand Down
59 changes: 30 additions & 29 deletions src/services/JobCandidateProcessorService.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Jobcandidate Processor Service
*/

const Joi = require('@hapi/joi')
const Joi = require('joi')
const logger = require('../common/logger')
const helper = require('../common/helper')
const constants = require('../common/constants')
Expand Down Expand Up @@ -74,34 +74,35 @@ async function processUpdate (message, transactionId) {
})
}

processUpdate.schema = {
message: Joi.object()
.keys({
topic: Joi.string().required(),
originator: Joi.string().required(),
timestamp: Joi.date().required(),
'mime-type': Joi.string().required(),
key: Joi.string().allow(null),
payload: Joi.object()
.keys({
id: Joi.string().uuid().required(),
jobId: Joi.string().uuid().required(),
userId: Joi.string().uuid().required(),
createdAt: Joi.date().required(),
createdBy: Joi.string().uuid().required(),
updatedAt: Joi.date().allow(null),
viewedByCustomer: Joi.boolean().required(),
updatedBy: Joi.string().uuid().allow(null),
status: Joi.jobCandidateStatus().required(),
externalId: Joi.string().allow(null),
resume: Joi.string().uri().allow(null).allow(''),
remark: Joi.stringAllowEmpty().allow(null)
})
.required()
})
.required(),
transactionId: Joi.string().required()
}
processUpdate.schema = Joi.object()
.keys({
message: Joi.object()
.keys({
topic: Joi.string().required(),
originator: Joi.string().required(),
timestamp: Joi.date().required(),
'mime-type': Joi.string().required(),
key: Joi.string().allow(null),
payload: Joi.object()
.keys({
id: Joi.string().uuid().required(),
jobId: Joi.string().uuid().required(),
userId: Joi.string().uuid().required(),
createdAt: Joi.date().required(),
createdBy: Joi.string().uuid().required(),
updatedAt: Joi.date().allow(null),
viewedByCustomer: Joi.boolean().required(),
updatedBy: Joi.string().uuid().allow(null),
status: Joi.jobCandidateStatus().required(),
externalId: Joi.string().allow(null),
resume: Joi.string().uri().allow(null).allow(''),
remark: Joi.stringAllowEmpty().allow(null)
})
.required()
})
.required(),
transactionId: Joi.string().required()
})

module.exports = {
processUpdate
Expand Down
93 changes: 49 additions & 44 deletions src/services/JobProcessorService.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Job Processor Service
*/

const Joi = require('@hapi/joi')
const Joi = require('joi').extend(require('@joi/date'))
const logger = require('../common/logger')
const helper = require('../common/helper')
const constants = require('../common/constants')
Expand Down Expand Up @@ -50,49 +50,54 @@ async function processCreate (message, transactionId) {
})
}

processCreate.schema = {
message: Joi.object()
.keys({
topic: Joi.string().required(),
originator: Joi.string().required(),
timestamp: Joi.date().required(),
'mime-type': Joi.string().required(),
payload: Joi.object()
.keys({
id: Joi.string().uuid().required(),
projectId: Joi.number().integer().required(),
externalId: Joi.string().allow(null),
description: Joi.stringAllowEmpty().allow(null),
title: Joi.title().required(),
startDate: Joi.date().allow(null),
duration: Joi.number().integer().min(1).allow(null),
numPositions: Joi.number().integer().min(1).required(),
resourceType: Joi.stringAllowEmpty().allow(null),
rateType: Joi.rateType().allow(null),
workload: Joi.workload().allow(null),
skills: Joi.array().items(Joi.string().uuid()).required(),
roles: Joi.array().items(Joi.string().uuid()).allow(null),
createdAt: Joi.date().required(),
createdBy: Joi.string().uuid().required(),
updatedAt: Joi.date().allow(null),
updatedBy: Joi.string().uuid().allow(null),
status: Joi.jobStatus().required(),
isApplicationPageActive: Joi.boolean().required(),
minSalary: Joi.number().integer().allow(null),
maxSalary: Joi.number().integer().allow(null),
hoursPerWeek: Joi.number().integer().allow(null),
jobLocation: Joi.stringAllowEmpty().allow(null),
jobTimezone: Joi.stringAllowEmpty().allow(null),
currency: Joi.stringAllowEmpty().allow(null),
roleIds: Joi.array()
.items(Joi.string().uuid().required())
.allow(null)
})
.required()
})
.required(),
transactionId: Joi.string().required()
}
processCreate.schema = Joi.object()
.keys({
message: Joi.object()
.keys({
topic: Joi.string().required(),
originator: Joi.string().required(),
timestamp: Joi.date().required(),
'mime-type': Joi.string().required(),
payload: Joi.object()
.keys({
id: Joi.string().uuid().required(),
projectId: Joi.number().integer().required(),
externalId: Joi.string().allow(null),
description: Joi.stringAllowEmpty().allow(null),
title: Joi.title().required(),
startDate: Joi.date().format('YYYY-MM-DD').allow(null),
duration: Joi.number().integer().min(1).allow(null),
numPositions: Joi.number().integer().min(1).required(),
resourceType: Joi.stringAllowEmpty().allow(null),
rateType: Joi.rateType().allow(null),
workload: Joi.workload().allow(null),
skills: Joi.array().items(Joi.string().uuid()).required(),
roles: Joi.array().items(Joi.string().uuid()).allow(null),
createdAt: Joi.date().required(),
createdBy: Joi.string().uuid().required(),
updatedAt: Joi.date().allow(null),
updatedBy: Joi.string().uuid().allow(null),
status: Joi.jobStatus().required(),
isApplicationPageActive: Joi.boolean().required(),
minSalary: Joi.number().integer().allow(null),
maxSalary: Joi.number().integer().allow(null),
hoursPerWeek: Joi.number().integer().allow(null),
jobLocation: Joi.stringAllowEmpty().allow(null),
jobTimezone: Joi.stringAllowEmpty().allow(null),
currency: Joi.stringAllowEmpty().allow(null),
roleIds: Joi.array()
.items(Joi.string().uuid().required())
.allow(null),
showInHotList: Joi.boolean().default(false),
featured: Joi.boolean().default(false),
hotListExcerpt: Joi.stringAllowEmpty().default(''),
jobTag: Joi.jobTag().default('')
})
.required()
})
.required(),
transactionId: Joi.string().required()
})

/**
* Process update entity message
Expand Down