Skip to content

Interview completed email notification should not be sent #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

xxcxy
Copy link
Contributor

@xxcxy xxcxy commented Sep 9, 2021

Interview completed email notification should not be sent if action was taken on the Job Candidate

verification: https://monosnap.com/file/RQOMFXD4G8aRRbYthNJCyxXzHfQPsR

fix: #541

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xxcxy it works good, but demo data created by the demo script doesn't verify this case.

If I comment the next lines, I would expect that upcoming interview notifications would be generated for 2 interviews. But they are only generated for one even though the error is not shown anymore.

if (!jcMap[interview.jobCandidateId] || jcMap[interview.jobCandidateId].status !== constants.JobCandidateStatus.INTERVIEW) {
      localLogger.error(`Interview id: ${interview.id} job candidate status is not ${constants.JobCandidateStatus.INTERVIEW}`)
      continue
    }

@xxcxy
Copy link
Contributor Author

xxcxy commented Sep 9, 2021

fixed the data

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xxcxy works good.

@maxceem maxceem merged commit 3c04b80 into topcoder-platform:dev Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interview completed email notification should not be sent if action was taken on the Job Candidate
2 participants